Jérémie Bresson

Results 204 comments of Jérémie Bresson
trafficstars

I think I have something working. I looked how the [maven-plugin of the props2yaml](https://github.com/Codearte/props2yaml/tree/master/maven-plugin) project was using the [takari-plugin-testing-project](https://github.com/takari/takari-plugin-testing-project) So I created a task `generateTakariTestResources` to create some metadata files...

If the request works with Postman, what you can try to do is to enable logging of HTTP request/response to understand what is going on. Here is how: ```java new...

This is addressed by https://github.com/gitlab4j/gitlab4j-api/pull/1113, not?

You mean: https://github.com/gitlab4j/gitlab4j-api/blob/6c06521abedebedad64a47b48960f570fba48dd7/src/main/java/org/gitlab4j/api/ProjectApi.java#L1344-L1346 `&& !project.getTopics().isEmpty()` should be removed? Then the semantic would be: * `null`: no change * empty list: remove the topics. Maybe I didn't get you right.

This requires more tests. I did not find the endpoint in the documentation, but I found a test case here: https://gitlab.com/gitlab-org/gitlab/-/blob/87385d7e0203c37dc97d4f9845cfe9860c33d2f3/spec/requests/api/branches_spec.rb#L629 Which is using `PUT` and not `DELETE`

The documentation says: https://docs.gitlab.com/ee/api/protected_branches.html#unprotect-repository-branches ``` DELETE /projects/:id/protected_branches/:name ```

Good finding, often the models in this project are a little behind the official API. A PR to add the missing field is welcome. --> You need to add it...

Probably, often the models in this project are a little behind the official API. Can you point to the GitLab documentation? A PR to add the missing field is welcome.

The change `int` -> `Long` in the models is a good idea, but it is breaking on the `5.x` stream. Would it be OK to do this change only on...