RegressionTables.jl icon indicating copy to clipboard operation
RegressionTables.jl copied to clipboard

Stop relying on `TableRegressionModel`

Open nalimilan opened this issue 3 years ago • 1 comments
trafficstars

We're going to stop using TableRegressionModel in GLM.jl (https://github.com/JuliaStats/GLM.jl/pull/339) as it's really not convenient for users to have that wrapper instead of just working with LinearModel and GeneralizedLinearModel. TableRegressionModel will probably be deprecated soon in StatsModels.

I see that RegressionTables.jl is one of the few packages that use TableRegressionModel. In particular standardized coefficients are only supported for these models: https://github.com/jmboehm/RegressionTables.jl/blob/e13df11078b6f1bb145574d55bedcfdaa6dbb1b7/src/regtable.jl#L197-L198 IIUC, you use this to detect that some models are GLM.jl objects and access their private fields. I suspect you could achieve the same result for any model (not just GLM) by calling modelmatrix and response instead. Can you confirm this? It would be too bad to lose support for GLM.jl in RegressionTables.jl.

nalimilan avatar Sep 11 '22 10:09 nalimilan

Yes, I've been meaning for a while to write this in a more general way. In any case I'll make sure that GLM.jl will always be supported.

jmboehm avatar Sep 11 '22 11:09 jmboehm