Jade Mattsson

Okay, I've submitted PR #3652 - please take a look. It should address: - CR/LF translation - Inability to use `uart.on('data')` on the console uart - No way to determine...

While I like not having errors thrown needlessly, I don't see how we could find out the correct return value in the reject case?

We currently return the wakeup cause from this function, but I guess we could use `ESP_SLEEP_WAKEUP_UNDEFINED` for the sleep-rejected case? Not sure whether that's cleaner that the current behaviour though?

`EXCVADDR: 0x00000003` That's effectively a null pointer dereference crash. Probably into the second element of a struct with a 32bit first element. If you use `idf.py monitor` you'll probably get...

Ah, one other review comment - the documentation needs to be linked in `mkdocs.yml` too :)

@bv73 This could potentially be because you still have the IDF-default CR/LF configuration in your sdkconfig file. I only changed the `sdkconfig.defaults`, which would not override any existing full sdkconfig...

Huh. That should not be the case. According to the documentation all line ending translation should be disabled when the setting is at `LF`. I am puzzled. If you have...

@bv73 Okay, this was totally my fault for managing to hardcode line ending settings 😬 I've updated the PR to actually use the Kconfig settings for line endings. I _believe_...

@bv73 Excellent, great to hear it! Thank you for testing! To answer the off-topic part - see Ivan's answer in https://github.com/espressif/esp-idf/issues/5051

This should now be fixed by PR #3652 having been merged.