junction-tree icon indicating copy to clipboard operation
junction-tree copied to clipboard

Published 20 hours ago • verified publisher icon jluttine

Fixed send message computations in Schafer-Shenoy

Open dar326 opened this issue 3 years ago • 2 comments

Fixed index mismatches causing #13 results and non-reproducibility. Removed remove_messages function so that excluded message is not included in the product of messages calculation rather than trying to remove it after product is computed.

dar326 avatar Mar 17 '22 03:03 dar326

Sorry about committing those files in the wrong location. The versions in the root directory were deleted and the two updated files are in the junctiontree directory where they belong.

dar326 avatar Apr 05 '22 01:04 dar326

Most recent changes to computation.py are a direct implementation of the Shafer-Shenoy updates. My original implementation attempted some optimizations of the code prematurely resulting in an incorrect implementation. This implementation uses Einstein summations for all computations. As a result, there are no longer concerns about matrix index mismatches and the code is simplified.

dar326 avatar Apr 23 '22 16:04 dar326