Jonathan Lebon

Results 650 comments of Jonathan Lebon

OK, I *finally* got to the bottom of the CI failure here. Debugging this was way more involved than I expected though I did learn a bunch along the way!...

This is probably some interaction with our passwd/group handling for layered packages `%pre` scripts which our tests aren't covering.

Ahh looks like #1745 conflicted. Mind rebasing?

I think the first code block is missing a `-A` in the `rpm-ostree install` invocation, right? The way `apply-live` works, you can keep accumulating changes in the pending deployment without...

Another approach is to return a special exit code which can conveniently then be used in systemd units with e.g. `RestartForceExitStatus=`.

I think this will likely require distro-level integration to work. It might be better to move this to https://github.com/coreos/fedora-coreos-tracker, but we can leave it here for now.

> It would also be nice if I could have more than one `conditional-include` statement in a single file, but I don't know if that's possible. That one should probably...

> By the way: > > I wanted to get rid of the default shell extensions. When I tried to delete them, I got an error because they are dependencies...

Yeah, exactly. The dependency should've been listed directly in the manifest `packages` section. But we didn't realize that until it was too late and removed when the package that previously...

Ahh right. This was fixed in #1632 but then regressed in #1852 as part of adding EVR grouping. And of course, we don't have any test that checks that we...