Jonathan Lebon
Jonathan Lebon
/cc @thom311 @bengal
An alternative is to tweak the conditional to check whether the directory is non-empty (skipping over the README) to know if ifcfg files are in use, but that creates a...
> `TEST-60-BONDBRIDGEVLANIFCFG` using the `network-legacy` module in Fedora needs to be addressed: [dracutdevs/dracut/actions/runs/6353041817/job/17256980641?pr=2529#step:4:1186](https://github.com/dracutdevs/dracut/actions/runs/6353041817/job/17256980641?pr=2529#step:4:1186) > > The `ifcfg` module is required and not automatically included. See an old run, e.g.: [dracutdevs/dracut/actions/runs/6309637128/job/17129970526?pr=2527#step:4:101](https://github.com/dracutdevs/dracut/actions/runs/6309637128/job/17129970526?pr=2527#step:4:101)...
> > Hmm OK, I'm not sure if I'm following the testing code properly. Do I just need a `-m network-legacy` [here](https://github.com/dracutdevs/dracut/blob/2b1f338fab83d95ab46cdaecd11f28cf9308669b/test/TEST-60-BONDBRIDGEVLAN/test.sh#L367)? > > @jlebon can you please try to...
Testing on Fedora CoreOS rawhide looks good. It also worked before this patch, but I didn't dig deeply into why (all the preconditions mentioned in https://github.com/dracutdevs/dracut/pull/2609#issuecomment-1894824013 are met).
I *think* the reason this happens in the case of `create_disk.sh` at least is that `DEFAULT_TERMINAL=$(. "$(dirname "$0")"/cmdlib.sh; echo "$DEFAULT_TERMINAL")` line. ShellCheck sees the `arch=` assignment in `cmdlib.sh` and the...
Would love to see this happen too. For reference, here's a permalink to the relevant docs since the one in the first comment is now broken: https://github.com/libgit2/libgit2/blob/68a3c0b1244687ce07c3d8605e875485d86b05ff/docs/threading.md Relevant excerpt: >...
Bit-level reproducibility is currently not a goal of coreos-assembler. Given the work that went into rpm-ostree to make composes reproducible, it probably wouldn't be too hard to at least make...
> My understanding was that's one of the main intents, reproducible ostree commits. No, it hasn't really been a focus, but it'd definitely be nice to support. That would also...
I won't speak for the other maintainers but I'd accept patches to enable this at least for the ostree compose (assuming they're not invasive, which I don't think they would...