Jonathan Lebon

Results 653 comments of Jonathan Lebon

:+1: from me. This is disruptive, but worth it long-term. (Also, for anyone not familiar, check out `git log -S` if you don't use it yet. It'll often get you...

If we do this, we probably also want to do the same thing as in https://github.com/coreos/rpm-ostree/pull/3604.

Looks like the impact to `git blame` can be minimized: https://mobile.twitter.com/pamelafox/status/1556779165247893506.

OK, so the timestamp jump appears here: ``` Sep 19 08:34:19 rauros.figura.io returntrip[26622]: 50mounted-tests: debug: running subtest /usr/libexec/os-probes/mounted/90linux-distro Sep 19 08:52:45 rauros.figura.io returntrip[26622]: 90linux-distro: result: /dev/nvme0n1p5:Antergos Linux:Antergos:linux ``` Which lead...

What kind of setup do you have (e.g. what storage device)? Do other disk operations take a long time to finish? Or is it isolated to OSTree finalization? Is it...

I think this needs a rebase too on top of fixed CI.

Hmm OK, so just thinking about this some more and looking at the FCOS side; do we want to think more deeply about what the ideal integration would look like...

Hmm, or maybe we add `-o json`? (This came up recently in https://github.com/ostreedev/ostree/issues/2469 for `ostree admin status` too.)

We do this in rpm-ostree using json-glib's [`json_gvariant_serialize`](https://github.com/coreos/rpm-ostree/blob/5d93072f91e4b336baba1c703f8c47afc64010c2/src/app/rpmostree-builtin-status.cxx#L1198). But yeah, it'd be a new dep for ostree.