jkyeung

Results 44 comments of jkyeung
trafficstars

> > Would you consider having the next version just rely on the Rust version through `pyo3` to realize performance benefits for the Python interface? > > I don't think...

I think it's worth noting that [PEP 8](https://www.python.org/dev/peps/pep-0008/) explicitly allows the closing bracket to line up in either of the following ways: ```python my_list = [ 1, 2, 3, 4,...

If you or *active* volunteers (I don't count myself as active) really want this, I won't object, but I won't be a fan. I am in the camp that has...

Well, `rows` is meant to be an iterator. Iterators cannot be accessed by arbitrary index, they can only be accessed one element at a time starting from the beginning.

Wait a minute. Are you just leaving *yourself* notes for planned fixes and new features? You should use a better example than `ws.rows[1]` because that would be the second row,...

Yeah, choosing indexing when you've got one foot in a 0-based environment and the other foot in a 1-based environment is always tricky. I don't mean to dictate your choice;...

Is there any style guide or even informal conventions? I have proofreader-level nitpickiness and occasionally have an urge to clean things up. Example: I notice that there are several small...

Sorry for being kind of off-topic, but how the heck do you satisfy the DCO check from the GitHub web interface? Is it even possible? Is there some place I...

Thanks for the response, @abmusse - for now I am OK with just manually entering the signed-off-by line. I finally was able to pass the DCO check by using my...

Sounds doable but tedious to me. To do a "proper" import, you'd need to be able to handle any arbitrary function being customized. I don't know if the full list...