Jan Kotas

Results 410 comments of Jan Kotas
trafficstars

> Did you mean to select .NET 9 instead of .NET 8? Also, will this be in Preview 6 or 7? Fixed - .NET 9 Preview 6.

@ilonatommy "Error: Index was outside the bounds of the array." error message is very generic, and it is likely going to match against unrelated failures. I have edited the matching...

@stephentoub The test name alone is typically too broad error pattern (https://github.com/dotnet/runtime/blob/main/docs/workflow/ci/failure-analysis.md#bad-usage-examples mentions it). I have updated the matching pattern to be more specific.

Full log: ``` [FAIL] System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpRequestErrorTest_Http30.SecureConnectionError Assert.Throws() Failure: Exception type was not an exact match Expected: typeof(System.Net.Http.HttpRequestException) Actual: typeof(Xunit.Sdk.SameException) ---- Assert.Same() Failure: Values are not the same instance Expected: Activity {...

> The ErrorMessage seems to match different unrelated issues The failures are hit in different tests, but all of them have to do with ActivityRecorder. I just saw a hit...

> GCInfo v1 is effectively dead - either on .Net FX or on CoreCLR ? Sounds like it.

The GCInfo change was merged into .NET 10 main. The commands to dump GCInfo are broken in SOS as of right now.

This is about https://github.com/dotnet/diagnostics/blob/main/src/shared/vm/gcinfodecoder.cpp and related files. Was this decoder rewritten in C#? I am not aware of it.

Yes, it lives at https://github.com/dotnet/diagnostics/blob/main/src/shared/vm/gcinfodecoder.cpp Note that this copy needs to be able to decode GCInfo for both current and past runtimes. The current copy in dotnet/runtime is not able...