python-bchlib icon indicating copy to clipboard operation
python-bchlib copied to clipboard

Adding support for Galois field orders up to 31

Open Ben-Mathews opened this issue 5 years ago • 3 comments

The version of bch.c that python-bchlib wraps only supports GF orders up to 15. This change extends support for GF orders up to 31.

Ben-Mathews avatar Dec 27 '19 17:12 Ben-Mathews

Hi Ben,

Since the change simple enough, do you think you can get this into the Linux kernel? I don't want to diverge from the kernel code if I don't have to.

Thanks for your contribution!

jkent avatar Dec 27 '19 23:12 jkent

Hi Jeff - Sorry for the delay. That makes complete sense and I figured that would be your response but wanted to make you aware of the change. Thank you for publishing such a useful Python wrapper! I'll submit the change to the kernel and hopefully they'll accept it.

Ben-Mathews avatar Jan 18 '20 04:01 Ben-Mathews

Let me know if they reject it, I'll merge in that case!

On Fri, Jan 17, 2020, 10:10 PM Ben Mathews [email protected] wrote:

Hi Jeff - Sorry for the delay. That makes complete sense and I figured that would be your response but wanted to make you aware of the change. Thank you for publishing such a useful Python wrapper! I'll submit the change to the kernel and hopefully they'll accept it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jkent/python-bchlib/pull/20?email_source=notifications&email_token=AAEH7M2XZXYAEIU6Z37SARTQ6J6KDA5CNFSM4J77FYS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJJP5HA#issuecomment-575864476, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEH7M4FVWPTZBYZ6B4X36LQ6J6KDANCNFSM4J77FYSQ .

jkent avatar Jan 18 '20 04:01 jkent

Since this has never made it upstream, I'm going to go ahead and merge it so you get credit in the next major release.

jkent avatar Aug 07 '23 14:08 jkent