John Keech

Results 55 comments of John Keech

We decided to move forward with the `alias` idea so that we can safely rename a feature, and if the `devcontainer-feature.json` has an `alias` property, we will continue to publish...

@metaskills, did you ever get this working? I did some searching and found that for private packages, you need to declare permissions bi-directionally in two places: in the consuming repo...

Glad to hear it worked! Yes, I think either approach would work, although managing the PAT manually with the `CODESPACES_PREBUILD_TOKEN` secret might be more of a maintenance challenge over time...

It might be even better if we can prefix the log lines (in the file-based logging, not the live TTY terminal stream) with the lifecycle hook name: ``` 2022-08-17 20:53:45.123Z:...

Thanks for reporting! I believe all of the non-printable characters are already wrapped with escaped square brackets in https://github.com/devcontainers/features/blob/main/src/common-utils/scripts/bash_theme_snippet.sh as well as the zsh variant, but the theme prompt is...

> All the actual non-printable characters _are_ wrapped, but the arrow is causing issues and removing or wrapping it fixes those issues. It's not non-printable, which is why I don't...

> I'm on Debian sid, I'm using `devcontainer exec bash`; I see the same behavior with neovim terminal, tmux, and alacritty, so I assume that this is just a case...

> I can also reproduce with `docker exec`. Does this indicate that the `PS1` value needs additional wrapping? I checked all of the escapes in https://github.com/devcontainers/features/blob/main/src/common-utils/scripts/bash_theme_snippet.sh is they look correct...

Here's a more minimal repro: ```bash docker run --rm -it mcr.microsoft.com/devcontainers/base:ubuntu echo ➜ ``` Then hit the up and down arrow back and forth and notice one character is overwritten...