goldensun_html5 icon indicating copy to clipboard operation
goldensun_html5 copied to clipboard

Combat freeze after selecting Garet's Djinn option

Open JCalHij opened this issue 2 years ago • 4 comments

While battling Briggs and its party, the whole game froze. Logs show this error:

Uncaught TypeError: Cannot read properties of undefined (reading 'name')
    at g.preview_djinn_change (MainChar.ts:608:36)
    at e.DjinnStatsWindow.set_stats (DjinnStatsWindow.ts:107:42)
    at e.DjinnStatsWindow.set_djinn (DjinnStatsWindow.ts:131:14)
    at e.BattleDjinnWindow.update_stats (BattleDjinnWindow.ts:251:27)
    at e.BattleDjinnWindow.mount_window (BattleDjinnWindow.ts:259:14)
    at e.BattleDjinnWindow.open (BattleDjinnWindow.ts:375:14)
    at e.MainBattleMenu.on_ability_choose (MainBattleMenu.ts:227:16)
    at e.MainBattleMenu.inner_button_press (MainBattleMenu.ts:185:22)
    at e.HorizontalMenu.on_press (HorizontalMenu.ts:75:51)
    at e.ControlManager.p (ControlManager.ts:247:29)

I chose a Djinn from Isaac, then tried to choose a Djinn action for Garet.

image

JCalHij avatar Oct 08 '23 08:10 JCalHij

I'll be taking a look at it. Many thanks for finding it!

jjppof avatar Oct 08 '23 14:10 jjppof

I wasn't able to reproduce it. That's a weird issue, how were you able to make Garet become a Squire? The error msg you pointed seems to be class related. What's the djinn configuration you used? Did you make any changes in class_db.json? If you can give a more specific step-by-step to reproduce the issue, it's going to help a lot.

Many thanks!

jjppof avatar Oct 09 '23 02:10 jjppof

I have tried reproducing it as well in the demo, but I wasn't able either. As far as I know, I got the Mars Djinn that appears on town, grabbed a couple chests then fought Briggs.

What's the djinn configuration you used?

Only Djinn swap was between Isaac and Garet (Flint <-> Fever). I cannot remember the exact things I did during combat, but I revived Garet on the previous turn with Quartz.

Did you make any changes in class_db.json?

Playing directly on the browser demo.

That's a weird issue, how were you able to make Garet become a Squire?

I think the engine might be holding some reference to Isaac or something, as it is not possible that Garet becomes a Squire.

JCalHij avatar Oct 09 '23 06:10 JCalHij

I think the engine might be holding some reference to Isaac or something, as it is not possible that Garet becomes a Squire.

That's a good point, will check something in this sense.

Thanks

jjppof avatar Oct 10 '23 02:10 jjppof