jira-importer

**[Robert Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)** commented If it would have been the main jar, you would have a real issue which would require the same kind of actions. The corrupt jar isn't a...

**[Elliotte Rusty Harold](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=elharo)** commented I've certainly seen problems like this before, multiple times, though not with the shade plugin. In general it would be nice if Maven did validate files...

**[Robert Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)** commented We had this discussion with a couple of Maven teammember and Mark Reinhold at FOSDEM and we came to the conclusion we should never merge module descriptors....

**[Romain Manni-Bucau](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=romain.manni-bucau)** commented I know but it literally means "dont use shade plugin from now on" and "no migration of shade usages". Im sure we - or oracle - can...

**[Robert Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)** commented Let's define the usecases first (maybe with ITs), otherwise the discussion is too abstract. The chance is that modularization does solve some issues we used to solve...

**[Romain Manni-Bucau](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=romain.manni-bucau)** commented Ok, my direct use case is xbean (from geronimo) project. We do several shades and since asm has now some module-info, we need to merge it properly....

**[Robert Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)** commented Not sure you are aware of it, but with MSHADE-258 module-info files are already removed. The idea is that if you don't add a module descriptor, then...

**[Romain Manni-Bucau](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=romain.manni-bucau)** commented Hmm, was not aware and tested and older version Can be a start if it validates the module name presence - but it is not enough since...

**[Robert Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)** commented Just to be sure we're on the same page, can you create a minimal project or setup of projects to show what you want to achieve?

**[Romain Manni-Bucau](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=romain.manni-bucau)** commented Created https://github.com/rmannibucau/sample-shade-java9 representing a simple case for lib just one step more complicated than asm (which just exports everything). Does it help enough?