jira-importer

**[François Loison](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=loizbak)** commented Previous answer was partially correct. I had a test-compile failure for a project containing a JAXB XSD to java generation. Old code was trying to patch unmodularized...

**[Robert Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)** commented What's the exception you get without junit? And I noticed code for multirelease in test. That's unrelated to this issue and I wonder if we should support...

**[François Loison](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=loizbak)** commented The exception is this one: javac -d target\test-classes ^ -classpath target\test-classes;..\prj1\target\test-classes;%LOCAL_REPO%\junit\junit\3.8.2\junit-3.8.2.jar; ^ --module-path target\classes;..\prj1\target\classes; ^ -sourcepath src\test\java;target\generated-test-sources\test-annotations; ^ -s target\generated-test-sources\test-annotations ^ -g -nowarn --release 11 -encoding UTF-8...

**[Robert Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)** commented I think the problem with junit is easy to fix: all patched modules should also have `--add-reads` for ALL-UNNAMED

**[Phillip Webb](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pwebb)** commented This issue is unfortunately quite important for Spring Boot users and as a result we're going use Maven Compiler 3.5.0 in the Spring Boot 1.4 parent POM....

**[Oliver Drotbohm](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=oliver.gierke)** commented Did you mean 3.5.0?

**[François Loison](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=loizbak)** commented Thanks for the tip. javac -d target\test-classes ^ -classpath target\test-classes;..\prj1\target\test-classes;%LOCAL_REPO%\junit\junit\3.8.2\junit-3.8.2.jar; ^ --module-path target\classes;..\prj1\target\classes; ^ -sourcepath src\test\java;target\generated-test-sources\test-annotations; ^ -s target\generated-test-sources\test-annotations ^ -g -nowarn --release 11 -encoding UTF-8 ^...

**[François Loison](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=loizbak)** commented Happy new year! I commited a new version in pull request. I build a list of test artifacts for each module. Then it adds a --patch-module instruction...

**[Phillip Webb](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pwebb)** commented Yes, edited the comment.

**[Robert Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)** commented Just had another look at this issue. The fix as suggested is not the right approach: test-jars don't have to come from the reactor, they can also...