Jamal Mustafa

Results 26 comments of Jamal Mustafa

This PR is at a good point for review. It may have went a bit overboard on the refactoring, with a lot of changes related to migrating to `plt.subplots` and...

Thanks @rougier for the comments. Many of the kwargs style config have been moved to mpl.rc near the top of the file, right after where the style sheets are specified....

> Ok, the PR is a bit too big for me to review everything and the use of the stylesheet makes it a bit harder. If the output is approximately...

> @jimustafa Would you have a link to the produced PDF by any chance? https://github.com/matplotlib/cheatsheets/suites/4674996554/artifacts/127245574 I also uploaded a small guide on finding the build artifacts for a PR (please...

I think the matplotlib version _should_ be pinned and match the version tag that is shown on the cheatsheets. That way, the cheatsheets will be built with a definite version...

> Again, I don't see the advantage of having a single script. I think it is easier to have well named isolated scripts that make things easier to find for...

It has been some time since the last discussion on this PR. With the recent activity on this repo, maybe it is a good time to revisit. @rougier, @jklymak, do...

> 1. The code is now more compact but if you consider the "educative" nature to the cheat sheets, we need to find the right balance between compactness of the...

Wanted to check on this... OK to merge?

Thank you @hammondkd! It seems that this could be a great addition to LAMMPS. And thanks for pointing me to your fork. Will take some time to check out the...