Jimmy Chen
Jimmy Chen
Looks like this PR needs another commit to trigger `target-branch-check`, I'll push an empty commit.
Re the unused helper functions, I guess you meant `LightClientHeader::new` (equivalent to the spec's [`block_to_light_client_header`](https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/light-client/full-node.md#block_to_light_client_header) function, may be worth adding a comment on top of the function). This will be...
FYI I created a PR that runs light client SSZ test vectors from `consensus-spec-tests` - if it's useful for testing your SSZ type changes, feel free to merge it into...
Awesome, I'll take a look later today or tomorrow!
Hi @ec2, Yes this PR is still active! We're currently reviewing #4969, and once that's merged we'll revisit this PR, hopefully won't be too long!
@eserilev #4969 has been merged 🎉 so it should unblock this PR! There are now some conflicts that needs to be resolved.
Sounds good! You can have `TestRandom` added to the superstruct variant attributes, so each generated struct derives it, like this: https://github.com/sigp/lighthouse/blob/31044402ee180ff937027ec842513bef90d7eec8/consensus/types/src/beacon_block_body.rs#L25-L55
@eserilev I've reviewed your `superstruct` PR and it looks good. I've added some small comments, but we're _really_ close!
btw @dapplion the optimistic updates & finality caching seems to be working great, response times were pretty much instant 🥳