json-validator icon indicating copy to clipboard operation
json-validator copied to clipboard

The CI tests are failing against even the slightest insignificant change

Open akarelas opened this issue 10 months ago • 2 comments
trafficstars

  • JSON::Validator version: 5.14
  • Perl version: all
  • Operating system: CI OS

Steps to reproduce the behavior

I only deleted an empty line in PR https://github.com/jhthorsen/json-validator/pull/279, that should have caused no discomfort to the tests.

Expected behavior

The tests should pass

Actual behavior

The tests did not pass, there were many test failures.

What does this show?

This shows that the CI of this module on github is not good.

Why is this significant?

Because I made a good PR a long time ago, and it was not taken into consideration because the tests, which NOW have finally been proven to be faulty, failed back then.

What do you want in the end?

For my previous PR https://github.com/jhthorsen/json-validator/pull/275 to be considered.

akarelas avatar Jan 13 '25 00:01 akarelas

Tests failing seems to be related to updates in Test::JSON::Schema::Acceptance 1.019+

I would love to help our, but Im not entirely sure where to start and how to fix this

I just hope this information can help moving forward

In the meanwhile, I will try to read up on this :)

HEM42 avatar Jan 14 '25 14:01 HEM42

Not that I have a fix, but the Test::JSON::Schema::Acceptance situation is the sort that made me add a schedule trigger to my GitHub workflows. The workflows run once a week to help me get visibility on dependency drift.

briandfoy avatar Jan 29 '25 17:01 briandfoy

I'm not going to run those tests automatically anymore. If anyone wants to become co-author and maintain them, then please let me know.

jhthorsen avatar Mar 16 '25 09:03 jhthorsen