Julien Hillairet
Julien Hillairet
@leonknight99-flann could you clean up the unused comment lines of code?
> @jhillairet Sorry been on holiday for the past few weeks, will get around to clearing the code and comments up hopefully in the next couple weeks @leonknight99-flann could you...
How about this PR ? Would be nice to include it in the next version, to be released soon.
@leonknight99-flann do you plan to finalize this PR?
Ok. Should we merge it like that?
@leonknight99-flann could you fix the conflicts and update this PR?
> This would be a great improvement. Is there something blocking from merging? some conflicts to address to start with... Otherwise I think it was OK.
> Hi, the linting comes up with this error: 'Error: skrf/calibration/tests/test_deembedding.py:576:58: W292 No newline at end of file' after I have copied that file from the main git page. Just...
You mean, after creating a `Network` using `Circuit` ?
It looks like to me that the performance increase are not very significant in comparison to the code complexity. Honestly, I prefer a code simpler to understand, in particular when...