diff-match-patch
diff-match-patch copied to clipboard
jheyne
Update for compatability with the dart dev compiler
Problem
I'm using this package in a project that we're keeping compatible with the ddc. The == implementation caused a compilation error.
Solution
Update the type signature to prevent the following error:
error: Invalid override. The type of 'Diff.==' ('(Diff) → bool') isn't a subtype of 'Object.==' ('(dynamic) → bool'). (strong_mode_invalid_method_override at [diff_match_patch] lib/src/diff/diff.dart:75)
@localvoid are there any other repo maintainers we should tag to review this?
@localvoid circling back to this. Is there anything we can do to help get this merged / released?
Sorry for the delayed response, github for some reason didn't showed unread notifications for this repo. If someone wants to properly maintain this repo and pub package, I can transfer it. Also, I've noticed that now there is an official port to Dart https://github.com/google/diff-match-patch/tree/master/dart
@localvoid I checked the google's official implementation. They are having the same issue.
@localvoid is the source code in the google repo the one used for the pub package, or is it this one?
@localvoid We would have to go through a few internal hoops to transfer this package to our org - would you be open to giving a Workiva member maintainer permissions on this project where it currently is?
@aaronlademann-wf this one is published at the diff_match_patch pub package.
@clairesarsam-wf sure. I'll transfer ownership over this repo and pub package, just need a github account to transfer this repo and email to transfer diff_match_patch pub package.
I upgraded this code to Dart 2.0, available at https://github.com/jheyne/diff-match-patch. Hopefully, my changes (or similar) will find it's way to this repository and pub.
@jheyne I've stopped using Dart, so it is better if someone who is actively working with Dart will take ownership over this repo/pub package. If you want to maintain it, I'll transfer it to you. I just need an email address to transfer pub package.
Sure, Boris -- thanks for your work on this.
Jim
On Sun, Oct 7, 2018 at 10:30 PM Boris Kaul [email protected] wrote:
@jheyne https://github.com/jheyne I've stopped using Dart, so it is better if someone who is actively working with Dart will take ownership over this repo/pub package. If you want to maintain it, I'll transfer it to you. I just need an email address to transfer pub package.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/localvoid/diff-match-patch/pull/2#issuecomment-427725187, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhaHB8KwR6o3XGF2wGinp2SpjMqh_Fbks5uiuMGgaJpZM4Vy8rz .