react-native-debugger icon indicating copy to clipboard operation
react-native-debugger copied to clipboard

`rndebugger-open` makes no action on RN 0.63.3

Open arthwood opened this issue 4 years ago • 0 comments

React Native Debugger app version: 0.11.6 react-native-debugger-open: 0.3.25 react-native: 0.63.3 @react-native-community/cli: 4.13.0 @react-native-community/cli-server-api: 4.13.0 Platform: iOS Is real device of platform: No Operating System: macOS

This is bit similar to #328, however in this caserndebugger-open command silently passes without making any patch.

Latest 0.3.25 version doesn't seem to support latest @react-native-community version as its structure has changed and apparently patch script should now target cli-server-api package rather than cli, meanwhile none of the rnFlags point to new location.

Also, I think result of this line https://github.com/jhen0409/react-native-debugger/blob/master/npm-package/src/injectDevToolsMiddleware.js#L183 should be returned (as well as the other branch of the same condition). Otherwise, as in described scenario, it returns false, however inject function returns true even though patch wasn't successful:

return (Array.isArray(flagList) ? flagList : [flagList]).some(flag => injectCode(modulePath, flag));

arthwood avatar Dec 30 '20 10:12 arthwood