keyring icon indicating copy to clipboard operation
keyring copied to clipboard

Installs 'ruby-keychain' dependency with 'gem install keyring' on Linux

Open zinga666 opened this issue 6 years ago • 1 comments
trafficstars

Hi,

if I am not mistaken the ruby-keychain dependency is not supposed to be installed (because not necessary/sensible) on Linux, is it?

When I install keyring (version 0.4.1) on my Linux (elementary OS Juno - based on ubuntu 18.04) with gem install (within rvm) it installs the ruby-keychain dependency.

$ gem install -V keyring
[...]
Successfully installed ruby-keychain-0.3.2
[...]
Building native extensions. This could take a while...
[...]
*linux: installing gir_ffi-gnome_keyring...
[...]
Successfully installed keyring-0.4.1
$ gem list -l key

*** LOCAL GEMS ***

gir_ffi-gnome_keyring (0.0.10)
keyring (0.4.1)
ruby-keychain (0.3.2)

The gem dependency command also lists it:

$ gem dependency keyring
Gem keyring-0.4.1
  bundler (~> 1.3, development)
  mocha (>= 0, development)
  rake (>= 0, development)
  ruby-keychain (~> 0.3.2)
  slop (< 4.0)

As well as the website on rubygems.org: https://rubygems.org/gems/keyring/versions/0.4.1

$ ruby -e 'puts Gem::Platform.local.os'
linux

It's not a big deal because (at least after installing the libgnome-keyring-dev libgirepository1.0-dev packages) the Gem works fine (with the Gnome keyring) but the commit(s) in 0.4.1 sound like the dependencies should be handled for the different platforms separately.

zinga666 avatar Sep 26 '19 13:09 zinga666

This is because the gemspec uses a runtime check but only the result of that check as run on the maintainer's machine is included in the final gem. It seems the maintainer uses a Mac.

mvz avatar Jul 22 '20 17:07 mvz