react-native-sketch icon indicating copy to clipboard operation
react-native-sketch copied to clipboard

draw on top of existing image

Open stantoncbradley opened this issue 9 years ago • 8 comments

Hi this library looks awesome! I need the ability to draw on top of an image (photo in my case) and then save/upload the new image (like snapchat). Would be a great feature addition!

Thanks!

stantoncbradley avatar Aug 25 '16 04:08 stantoncbradley

Hey @stantoncbradley! Thanks for the suggestion. Indeed, that'd be a great addition that I didn't think about when I started this project. I'll try to find some time to do it. But feel free to create a PR if you're keen! :)

jgrancher avatar Aug 29 '16 05:08 jgrancher

Working on it now! Currently hung up on getting the view dimensions when instantiating the image. I think I have an idea tho, will prob work on it more tomorrow

stantoncbradley avatar Aug 29 '16 05:08 stantoncbradley

How did you go @stantoncbradley . I'm interested in doing this too

benkaiser avatar Oct 22 '16 14:10 benkaiser

You can view/implement my fork @ https://github.com/stantoncbradley/react-native-sketch. I added an image file path prop then if it's there in obj-c used that as the initial image. Works for me reading pictures captured with react-native-camera from disc. Thing about images is they can come from various sources, I only supported the one I use. See my PR for more discussion on this https://github.com/jgrancher/react-native-sketch/pull/7. I ended up closing the PR because resizing was buggy as well. Hope that helps!

stantoncbradley avatar Oct 24 '16 00:10 stantoncbradley

Hi again @stantoncbradley! Did you, by any chance, find a way to resolve that resizing issue you were talking about? :)

jgrancher avatar Jan 20 '17 14:01 jgrancher

Was this ever done? I need this as well?

isAlmogK avatar Sep 07 '17 04:09 isAlmogK

I’m also curious on the status of this..

joshstilwell avatar Apr 28 '18 14:04 joshstilwell

This is something I need in my life :)

sverrirs15 avatar Apr 29 '18 00:04 sverrirs15