data-science-stack-cookiecutter icon indicating copy to clipboard operation
data-science-stack-cookiecutter copied to clipboard

Published 20 hours ago • verified publisher icon jgoerner

fix problem with python version

Open tduberne opened this issue 7 years ago • 4 comments

numpy failed to compile using the "latest" version from python:3 using python:3.6 fixes the issue

issue remains if using python:3.7

I did this fix for myself, and thought you might be interested in merging it back on your side (or find a solution you find more suitable ;-))

tduberne avatar Aug 02 '18 13:08 tduberne

Especially the makefile is useful! Thx @tduberne Is numpy still not compiling under 3.7?

plattenschieber avatar Sep 16 '18 00:09 plattenschieber

Thanks @tduberne for your support - the Makefile is indeed a helpful tool As asked by @plattenschieber, do you still encouter problems with the numpy compilation?

I will take a look at your PR as well as #2 and merge them ASAP.

jgoerner avatar Oct 22 '18 18:10 jgoerner

Hey @tduberne

Sorry for coming back so lately. As I seem to already changed the Python version in a previous commit that topic should be fixed - however I really like your Makefile approach and would be happy to include it in the codebase.

Since you came up with that idea (and deserve the kudos) I would appreciate if you might open another PR based on the newest version of this repo - including the Makefile.

Would that be fine with you?

jgoerner avatar Nov 27 '18 19:11 jgoerner

Sorry for the extremely late reply, this went buried in a massive amount of GitHub notifications...

No problem for the PR, I will do it

tduberne avatar Apr 12 '19 13:04 tduberne