John Firebaugh
John Firebaugh
I can confirm that this issue arises when package version resolution results in multiple versions of `@smithy/util-endpoints` being used at runtime. The way `@smithy/util-endpoints` is currently architected, with a [global...
This happens regularly on linux in CI for me: ``` #20 158.9 npm ERR! gyp http GET https://nodejs.org/download/release/v18.16.0/node-v18.16.0-headers.tar.gz #20 158.9 npm ERR! gyp http 200 https://nodejs.org/download/release/v18.16.0/node-v18.16.0-headers.tar.gz #20 158.9 npm ERR!...
@jacobgardner Thanks for working on this! I tested it out in our repo at Figma, and it works well. I did have to make an addition on top of your...
I've found another hiccup with this approach: when using it in tandem with [rules_lint](https://github.com/aspect-build/rules_lint) / [aspect lint](https://docs.aspect.build/cli/commands/aspect_lint), the typechecking actions will trigger even when you're just trying to run eslint....
A more serious issue with this approach is that it negates the performance optimization of using [`ts_project#transpiler`](https://docs.aspect.build/rulesets/aspect_rules_ts/docs/transpiler#ts_projecttranspiler) to avoid typechecking in situations when only the transpiled outputs are necessary. The...
I cloned the repository and tried `make -j8 native`: ``` ~/Development/node/deps/v8 $ make -j8 native GYP_GENERATORS=make \ build/gyp/gyp --generator-output="out" build/all.gyp \ -Ibuild/standalone.gypi --depth=. -S.native -Dv8_can_use_vfp3_instructions=true /bin/sh: build/gyp/gyp: No such file...
I ran into compile errors after that and gave up. However, copying deps/v8/tools/tickprocessor.js into place in a node-profiler checkout and rerunning build-nprof gave me a working nprof.
Good find! Do you think you'd be able to make a pull request to fix this?
I guess the way to work around this would be to check the scheme and host of the iframe before trying to access `contentWindow`. Happy to accept a pull request...
I'd be happy to see a pull request for this.