react-native-onboarding-swiper icon indicating copy to clipboard operation
react-native-onboarding-swiper copied to clipboard

Typescript definitions for flatlistProps

Open zemiret opened this issue 4 years ago • 1 comments

Hi. I was trying to use flatlistProps to tweak some properties, but the typescript definition for the type is:

flatlistProps?: FlatListProps<Page> | undefined;

And FlatListProps type requires data and renderItem props. I believe the type should be wrapped so that these fields are not required. Technically I could provide data as I see that this is just pages, but renderItem is some private function and trying to supply it kind of defeats part of this library's purpose.

zemiret avatar Aug 27 '21 17:08 zemiret

Yes, the type definitions are not correct:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/37f3515e1ae1c7da70797750a8e31da21542f0dd/types/react-native-onboarding-swiper/index.d.ts#L157

If anybody wants to help, please sumit a PR to https://github.com/DefinitelyTyped/DefinitelyTyped.

jfilter avatar Jan 31 '22 10:01 jfilter