jetty.project icon indicating copy to clipboard operation
jetty.project copied to clipboard

backward compat for ee10-security module which is now in jetty-ee10-servlet

Open olamy opened this issue 3 years ago • 1 comments

olamy avatar Aug 24 '22 10:08 olamy

@gregw jetty-10 have mixed together jetty-servlet and jetty-security so the ee10-security need to use jetty-ee10-servlet jar

olamy avatar Aug 25 '22 05:08 olamy

@olamy Can you check the status of this and ask for review if it is still needed

gregw avatar Feb 02 '23 21:02 gregw

@gregw it depends what we want to do exactly. ee9 has a Maven module jetty-ee9-security as so the correspond Jetty module ee9-security.mod ee10 doesn't have the same Maven module jetty-ee10-security so do we want/need to keep having a ee10-security.mod which should only have jetty-ee10-servlet-${jetty.version}.jar in it. the file ee10-security.mod will here only for a sort of backward compat so users can still use --add-module=ee9-security then --add-module=ee10-security where they do not need it. I don't really have strong opinion here

olamy avatar Feb 03 '23 01:02 olamy

@lachlan-roberts can you think about this one when you consider core security

gregw avatar Feb 03 '23 01:02 gregw

@olamy I think this has been addressed with the core security changes? Can we close?

gregw avatar Jun 06 '23 07:06 gregw

yes

olamy avatar Jun 06 '23 10:06 olamy