jetty.project icon indicating copy to clipboard operation
jetty.project copied to clipboard

Jetty 12 : Strengthen WebSocket upgrade contract and other improvements

Open lachlan-roberts opened this issue 3 years ago • 0 comments

  • Strengthen contract of WebSocket upgrade methods by defining in javadoc that an error response needs to be generated by them if they are not returning a WebSocket Object.
  • Remove WebSocketNegotiation from the public API, use (req, resp, cb) style method in WebSocketNegotiator instead.
  • Factor out a isWebSocketUpgradeRequest method for the Handshaker so that the Upgrade Servlet/Filters can check it is really an upgrade attempt before allocating the Blocking Callback and other resources.
  • Add Attachment interface onto the Servlet Request objects so the wrapped HttpServletRequest and HttpServletResponse can be stored there and retrieved once websocket-core calls back the API layer.

lachlan-roberts avatar Aug 04 '22 09:08 lachlan-roberts