Calling setLowResources() is a No-Op?

[praveenkjvs]

https://github.com/eclipse/jetty.project/blob/a55b315f14886e7dffd9c2ea7cfb378d66297843/jetty-server/src/main/java/org/eclipse/jetty/server/LowResourceMonitor.java#L306

Seems like calling setLowResources(), when we are already in LowResourceMode is a No-Op. Reason being, as soon as LowResourceMode is entered , the server socket(s) are set to not-accepting state. And then all the idle time out is set on all end point, that made way into the server , just before we set accepting to false. After that there are no new end points created, (because server socket is not accepting any new connections) until we come out low resource mode.

The case when the above argument is false, is when _acceptingInLowResources is to false?

Am I missing anything?

[sbordet]

@olamy can you look at this? The code is indeed weird.

[janbartel]

@olamy nudge

[github-actions[bot]]

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions[bot]]

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.