jetty.project
jetty.project copied to clipboard
jetty
Keep extracted query params as attribute for jetty-core
It feels like querry params would almost certainly have already been extracted at this point. Don't we store as an attribute or similar? Hmm apparently not... let's open another issue to investigate doing this in core (not just in servlet)
Originally posted by @gregw in https://github.com/jetty/jetty.project/pull/12877#discussion_r2141057460
Careful, that Attribute would need to be aware of changes to the HttpURI query and be cleared out every time we create a new Request Wrapper to modify the HttpURI.
That technique is likely safest to do at the Servlet level, not at the core level.
@joakime the servlet level already does it. But if we are to increasingly write core webapps, or if core is doing things like websocket upgrade, then it would be good to avoid parsing the query parameters again on each call. Perhaps we an have a check to see if the HttpURI has changed and if not, then we can use the cached query parameters.
