jetty.project icon indicating copy to clipboard operation
jetty.project copied to clipboard

Address naming of "core" components

Open joakime opened this issue 5 months ago • 3 comments
trafficstars

Jetty version(s) 12.1.0

Enhancement Description

There's a few things called "core" that are overlapping and are causing confusion within the group. Lets brainstorm a few ideas on how to make the naming more clear.

  • Core the environment
  • Core the jetty-core/ source tree and associated modules
  • Core the deployment techniques
  • Core the classloader loader

and more.

joakime avatar Jun 11 '25 21:06 joakime

My 2c is that:

  • core-deploy becomes coreapp-deploy, as it deploys CoreAppContexts
  • core env stays as core as it can deploy coreapps or core components
  • StatisticsContextHandler is a core component, It can be used by a coreapp, but it is not a coreapp
  • static-deploy remains the same. It used core components to serve static content.
  • jetty-core-webapp module should become jetty-coreapp

gregw avatar Jun 12 '25 02:06 gregw

As I started saying over here: https://github.com/jetty/jetty.project/pull/13220/files#r2141231426 I think that:

  • CoreContextHandler should become CoreAppContext so it is symmetric with WebAppContext and we can naturally refer to "core apps" and "web apps"
  • jetty-core-webapp subproject should become jetty-coreapp
  • org.eclipse.jetty.core.webapp should become org.eclipse.jetty.core.app package
  • jetty-core-demo-webapp subproject should be moved into the existing jetty-demos parent project, in a new subproject called jetty-coreapp-demos (note that we already have jetty-demos/jetty-core-demos) and renamed to jetty-coreapp-demo
  • jetty-core/jetty-core-test-webapps parent project should be renamed jetty-core/jetty-test-coreapps
  • jetty-core-bad-init-webapp subproject should be renamed jetty-test-coreapp-badinit
  • StaticContextHandler should be moved back into jetty-core/jetty-server - as it is not a core app, just a single handler - as should its associated static-deploy module
  • core-deploy becomes coreapp-deploy

janbartel avatar Jun 12 '25 04:06 janbartel

Opened PR to change the names (and move files)

  • #13241

joakime avatar Jun 12 '25 19:06 joakime

Merged PR #13241

joakime avatar Jun 18 '25 21:06 joakime