jetty.project
jetty.project copied to clipboard
Address naming of "core" components
trafficstars
Jetty version(s) 12.1.0
Enhancement Description
There's a few things called "core" that are overlapping and are causing confusion within the group. Lets brainstorm a few ideas on how to make the naming more clear.
- Core the environment
- Core the jetty-core/ source tree and associated modules
- Core the deployment techniques
- Core the classloader loader
and more.
My 2c is that:
core-deploybecomescoreapp-deploy, as it deploysCoreAppContextscoreenv stays ascoreas it can deploy coreapps or core componentsStatisticsContextHandleris a core component, It can be used by a coreapp, but it is not a coreappstatic-deployremains the same. It used core components to serve static content.jetty-core-webappmodule should becomejetty-coreapp
As I started saying over here: https://github.com/jetty/jetty.project/pull/13220/files#r2141231426 I think that:
CoreContextHandlershould becomeCoreAppContextso it is symmetric withWebAppContextand we can naturally refer to"core apps"and"web apps"jetty-core-webappsubproject should becomejetty-coreapporg.eclipse.jetty.core.webappshould becomeorg.eclipse.jetty.core.apppackagejetty-core-demo-webappsubproject should be moved into the existingjetty-demosparent project, in a new subproject calledjetty-coreapp-demos(note that we already havejetty-demos/jetty-core-demos) and renamed tojetty-coreapp-demojetty-core/jetty-core-test-webappsparent project should be renamedjetty-core/jetty-test-coreappsjetty-core-bad-init-webappsubproject should be renamedjetty-test-coreapp-badinitStaticContextHandlershould be moved back intojetty-core/jetty-server- as it is not a core app, just a single handler - as should its associatedstatic-deploymodulecore-deploybecomescoreapp-deploy
Opened PR to change the names (and move files)
- #13241
Merged PR #13241