jetty.project icon indicating copy to clipboard operation
jetty.project copied to clipboard

Support list of paths in DeploymentScanner webapps directories configuration from XML/INI

Open joakime opened this issue 6 months ago • 0 comments
trafficstars

Jetty version(s) 12.1.0

Enhancement Description Historically, we have not supported multiple paths in the jetty.deploy.monitoredDir INI property.

  • 12.0.19 - https://github.com/jetty/jetty.project/blob/jetty-12.0.19/jetty-core/jetty-deploy/src/main/config/etc/jetty-core-deploy.xml#L21-L30
  • 10.0.25 - https://github.com/jetty/jetty.project/blob/jetty-10.0.25/jetty-deploy/src/main/config/etc/jetty-deploy.xml#L42-L47
  • 9.4.57 - https://github.com/jetty/jetty.project/blob/jetty-9.4.57.v20241219/jetty-deploy/src/main/config/etc/jetty-deploy.xml#L41-L48

This is because the need to support relative path names from jetty.webapps (xml property).

If we decide we want to support this, then we should have the following changes.

  • To maintain consistency with how we use delimiters for paths in other areas, we should use , (comma) ; (semi-colon) and | (pipe) as the delimiters supported.
  • The setWebappsDirectories() method, should be passed two arguments.
    • String base - the base path to apply to paths to allow for proper support of relative paths (this is configured to to be the <Property name="jetty.webapps"/> in the XML, like you see in the above historical examples)
    • String paths - the delimited list of paths that are resolved against base (to mimic the behaviors you see in the above historical examples)

joakime avatar May 09 '25 14:05 joakime