jetty.project icon indicating copy to clipboard operation
jetty.project copied to clipboard

Fix issues with WebSocket UpgradeRequest after upgrade is complete

Open lachlan-roberts opened this issue 8 months ago • 3 comments
trafficstars

Issue https://github.com/jetty/jetty.project/issues/11294

  • Ensure that JetterServerUpgradeRequest and JetterServerUpgradeResponse are only used for the webscoket negotiation, and are not available from the UpgradeRequest and UpgradeResponse which can be obtained from the Session.
  • The UpgradeRequest and UpgradeResponse instances from the Session are now CompletedUpgradeRequest, which will copy any information it needs so it is not accessing the core Request/Response after the upgrade.
  • Wrap the servlet request/response as a Core request/response before it is passed to the WebSocketHandshaker.
  • Various other cleanups.

lachlan-roberts avatar Mar 06 '25 06:03 lachlan-roberts