jetty.project icon indicating copy to clipboard operation
jetty.project copied to clipboard

servlet 6.1 tck cookie test errors

Open janbartel opened this issue 1 year ago • 0 comments

Jetty version(s) jetty-12.1.x

Failing Test servlet.tck.api.jakarta_servlet_http.cookie.CookieTests.getValueQuotedTest

This test sends a cookie from the client to the server that is constructed like so:

"Cookie: name1=\"value1\"; Domain=" + _hostname + "; Path=/servlet_jsh_cookie_web"

The test expects that the value of the name1 cookie is interpreted by the server as "value1", ie that double quotes are retained.

Failing Test servlet.tck.api.jakarta_servlet_http.cookie.CookieTests.setMaxAgeZeroTest

The test creates a Cookie and calls setMaxAge(0) on it. The test expects that the Max-Age field will be missing on the Set-Cookie response header, but we are sending Max-Age=0. Looking at RFC6265 it does seem that Max-Age should never be 0:

max-age-av        = "Max-Age=" non-zero-digit *DIGIT

Failing Test servlet.tck.api.jakarta_servlet_http.cookie.CookieTests.setPartitionedTest

The test creates a Cookie and calls setAttribute("Partitioned", "") The test expects that a Set-Cookie will contain Partitioned, however, we only send Partitioned iff setAttribute("Partitioned", "true") was called.

janbartel avatar Jun 20 '24 07:06 janbartel