jetty.project icon indicating copy to clipboard operation
jetty.project copied to clipboard

Published 20 hours ago • verified publisher icon jetty

jetty-12.1 ee11 tck test failures

Open janbartel opened this issue 1 year ago • 6 comments
trafficstars

Jetty version(s) jetty-12.1

Jetty Environment ee11

List of currently failing ee11 tck tests to fix (check means it's fixed):

  • [x] servlet.tck.api.jakarta_servlet.servletcontext.ServletContextTests.GetMinorVersionTest
  • [x] servlet.tck.api.jakarta_servlet_http.cookie.CookieTests.getValueQuotedTest
  • [x] servlet.tck.api.jakarta_servlet_http.cookie.CookieTests.setMaxAgeZeroTest
  • [x] servlet.tck.api.jakarta_servlet_http.cookie.CookieTests.setPartitionedTest
  • [x] servlet.tck.api.jakarta_servlet_http.httpservletresponse.HttpServletResponseTests.sendError_StringTest
  • [x] servlet.tck.api.jakarta_servlet_http.httpservletresponsewrapper.HttpServletResponseWrapperTests.sendError_StringTest
  • [x] servlet.tck.api.jakarta_servlet_http.httpupgradehandler.HttpUpgradeHandlerTests.upgradeTest
  • [x] servlet.tck.pluggability.api.jakarta_servlet.servletcontext.ServletContextTests.GetMinorVersionTest
  • [x] servlet.tck.pluggability.api.jakarta_servlet_http.cookie.CookieTests.getValueQuotedTest
  • [x] servlet.tck.pluggability.api.jakarta_servlet_http.cookie.CookieTests.setMaxAgeZeroTest
  • [x] servlet.tck.pluggability.api.jakarta_servlet_http.cookie.CookieTests.setPartitionedTest
  • [x] servlet.tck.pluggability.api.jakarta_servlet_http.httpservletresponse.HttpServletResponseTests.sendError_StringTest
  • [x] servlet.tck.pluggability.api.jakarta_servlet_http.httpservletresponsewrapper.HttpServletResponseWrapperTests.sendError_StringTest
  • [x] servlet.tck.pluggability.fragment.FragmentTests.initParamTest
  • [x] servlet.tck.pluggability.fragment.FragmentTests.addServletURLTest
  • [x] servlet.tck.pluggability.fragment.FragmentTests.filterOrderingTest
  • [x] servlet.tck.pluggability.fragment.FragmentTests.addServletTest
  • [x] servlet.tck.pluggability.fragment.FragmentTests.welcomefileTest
  • [ ] servlet.tck.signature.ServletSigTest.signatureTest
  • [x] servlet.tck.spec.httpservletresponse.HttpServletResponseTests.flushBufferTest
  • [ ] servlet.tck.spec.serverpush.ServerPushTests.serverPushCookieTest

janbartel avatar Jun 19 '24 21:06 janbartel

Issue raised for TCK bug: https://github.com/jakartaee/servlet/issues/660. This affects the tests:

  • servlet.tck.api.jakarta_servlet_http.httpservletresponse.HttpServletResponseTests.sendError_StringTest
  • servlet.tck.api.jakarta_servlet_http.httpservletresponsewrapper.HttpServletResponseWrapperTests.sendError_StringTest
  • servlet.tck.pluggability.api.jakarta_servlet_http.httpservletresponse.HttpServletResponseTests.sendError_StringTest
  • servlet.tck.pluggability.api.jakarta_servlet_http.httpservletresponsewrapper.HttpServletResponseWrapperTests.sendError_StringTest

Update 25/06/24: there is an error in jetty's handling of error messages in ee11, for which a fix will be necessary (see branch https://github.com/jetty/jetty.project/tree/jetty-12.1.x-tck-error-message)

janbartel avatar Jun 20 '24 05:06 janbartel

Previously raised TCK bug: https://github.com/jakartaee/servlet/issues/525 applies to:

  • servlet.tck.spec.httpservletresponse.HttpServletResponseTests.flushBufferTest

Latest failure is: https://jenkins.webtide.net/job/tck/job/tck-servlet-arquillian/job/jetty-12-ee11/36/testReport/junit/servlet.tck.spec.httpservletresponse/HttpServletResponseTests/flushBufferTest/

janbartel avatar Jun 20 '24 05:06 janbartel

Need https://github.com/jetty/jetty.project/pull/10128 done in order for following test to pass:

  • servlet.tck.api.jakarta_servlet_http.httpupgradehandler.HttpUpgradeHandlerTests.upgradeTest

janbartel avatar Jun 20 '24 05:06 janbartel

Raised jetty issue https://github.com/jetty/jetty.project/issues/11934 to fix:

  • servlet.tck.api.jakarta_servlet_http.cookie.CookieTests.getValueQuotedTest
  • servlet.tck.pluggability.api.jakarta_servlet_http.cookie.CookieTests.getValueQuotedTest

Fixed via #11936

janbartel avatar Jun 20 '24 07:06 janbartel

Raised TCK bug: https://github.com/jakartaee/servlet/issues/661 applies to:

  • servlet.tck.spec.serverpush.ServerPushTests.serverPushCookieTest

Bug report not accepted, need to modify Jetty.

janbartel avatar Jun 20 '24 09:06 janbartel

Raised jetty issue #12004 to look at:

  • servlet.tck.signature/ServletSigTest/signatureTest/

janbartel avatar Jul 05 '24 01:07 janbartel

As of https://jenkins.webtide.net/job/tck/job/tck-servlet-arquillian/job/jetty-12-ee11/69/ we have a clean TCK run!

janbartel avatar Oct 02 '24 04:10 janbartel