jetty.project icon indicating copy to clipboard operation
jetty.project copied to clipboard

ChunkAccumulator read and readAll should be static

Open scrat98 opened this issue 1 year ago • 1 comments

Jetty version(s) 12.0.8

Enhancement Description

ChunkAccumulator.read and ChunkAccumulator.readAll methods create AccumulatorTask that's under the hood creates ChunkAccumulator instance and pass it to the take method, therefore I think it's more accurate to make these methods static

scrat98 avatar May 06 '24 15:05 scrat98

@scrat98 please note #11598 which deprecates ChunkAccumulator. It is still draft status, but we are working on improving this area of the code. So until we have decided on that, we are unlikely to make API changes here.

gregw avatar May 07 '24 03:05 gregw

@gregw then I think we can close this issue if eventually ChunkAccumulator will be removed

scrat98 avatar May 07 '24 17:05 scrat98