jetty.project icon indicating copy to clipboard operation
jetty.project copied to clipboard

Issue #11387: Reintroduce MultiPartCompliance.LEGACY in ee9/ee8

Open joakime opened this issue 1 year ago • 2 comments

Reintroduce MultiPartCompliance.LEGACY behaviors.

joakime avatar Feb 07 '24 19:02 joakime

For people reviewing this PR. Don't be scared by the number of files. Over 252 files are just moved and consolidated testcases from various parts of the codebase into a new tests/jetty-test-multipart module.

If you exclude (uncheck) the entries for .raw and .txt and Deleted Files in the "File Filter" drop-down, then the review becomes much easier to manage.

raw-txt-exclusions

joakime avatar Feb 14 '24 22:02 joakime

Do we have a test that parses multi-part form 1 byte chunks?

I don't know, but it shouldn't be that hard to setup.

joakime avatar Feb 15 '24 13:02 joakime

This PR is largely complete. But I'm waiting on PR #11409 to complete so I can update this PR and eliminate some of the no longer relevant noise from this PR.

joakime avatar Feb 20 '24 19:02 joakime