jetty.project icon indicating copy to clipboard operation
jetty.project copied to clipboard

implement servlet upgrade for ee10

Open lachlan-roberts opened this issue 2 years ago • 4 comments

implementing ee10 servlet upgrade for PR https://github.com/eclipse/jetty.project/pull/10064

lachlan-roberts avatar Jul 19 '23 07:07 lachlan-roberts

@lachlan-roberts is this still a thing?

gregw avatar May 23 '24 06:05 gregw

@gregw yes, but we need to discuss the issue with the callback.

  1. You say we should not execute the callback.
  2. Using SerializedInvoker like we did before causes it to block forever.
  3. Running the callback directly causes an infinite recursion.

So we need to think of some other solution for this.

lachlan-roberts avatar May 27 '24 01:05 lachlan-roberts

I am not executing this anymore, I have lots of changes which I have not pushed, will push them today.

lachlan-roberts avatar Jun 20 '24 01:06 lachlan-roberts

@lachlan-roberts we need this to pass the servlet 6.1 tck

janbartel avatar Jun 25 '24 09:06 janbartel

@lachlan-roberts nudge

janbartel avatar Jul 05 '24 01:07 janbartel

@lachlan-roberts can you please resolve the conflicts and then ensure that we have the simplest implementation that we can get committed?

janbartel avatar Jul 15 '24 07:07 janbartel

replaced by https://github.com/jetty/jetty.project/pull/12186

lachlan-roberts avatar Aug 21 '24 14:08 lachlan-roberts