jest icon indicating copy to clipboard operation
jest copied to clipboard

Allow detectOpenHandles in jest.config.js

Open clarkdo opened this issue 7 years ago • 8 comments

Summary

Current if config detectOpenHandles in jest.config.js, validation warning will be thrown:

● Validation Warning: Unknown option "detectOpenHandles" with value true was found. This is probably a typing mistake. Fixing it will remove this message.

Resolve warning in https://github.com/nuxt/nuxt.js/pull/3581

clarkdo avatar Jul 24 '18 09:07 clarkdo

LGTM! @clarkdo could you add an entry to the changelog?

mattphillips avatar Aug 09 '18 10:08 mattphillips

As mentioned in another issue (on mobile, so hard to dig up), detectOpenHandles was intentionally not added to config - the performance overhead is pretty bad (30+%). Once the performance overhead is gone (or reduced enough) we'll remove the flag as well and make the behavior the default

SimenB avatar Aug 09 '18 11:08 SimenB

@mattphillips Done

clarkdo avatar Aug 09 '18 16:08 clarkdo

Codecov Report

Merging #6747 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6747   +/-   ##
=======================================
  Coverage   63.44%   63.44%           
=======================================
  Files         235      235           
  Lines        9112     9112           
  Branches        4        4           
=======================================
  Hits         5781     5781           
  Misses       3330     3330           
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-config/src/valid_config.js 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d7eead1...ebcc568. Read the comment docs.

codecov-io avatar Aug 09 '18 21:08 codecov-io

The related comment that @SimenB mentioned: https://github.com/facebook/jest/pull/6130#issuecomment-386676404

TheAlexLichter avatar Sep 30 '18 22:09 TheAlexLichter

Would love to see this goes in @clarkdo

reuveniy avatar Oct 14 '18 14:10 reuveniy

@SimenB if we document the performance hit, would you be ok to add this to the config?

rickhanlonii avatar Oct 15 '18 02:10 rickhanlonii

This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Sep 08 '22 18:09 github-actions[bot]

This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.

github-actions[bot] avatar Oct 08 '22 19:10 github-actions[bot]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

github-actions[bot] avatar Nov 08 '22 00:11 github-actions[bot]