jest icon indicating copy to clipboard operation
jest copied to clipboard

Published 20 hours ago • verified publisher icon jestjs

fix: added inherited string keys check on `subsetEquality` method

Open lpizzinidev opened this issue 2 years ago • 3 comments

Summary

As a result of #13810, this fixes the subsetEquality method to consider also an object's inherited string keys.

lpizzinidev avatar Jan 26 '23 11:01 lpizzinidev

A test case would be nice so we avoid a regression in the future

SimenB avatar Jan 26 '23 14:01 SimenB

@SimenB What do you think a good regression test could be in this case?

lpizzinidev avatar Jan 27 '23 08:01 lpizzinidev

@joshkel thoughts?

SimenB avatar Jan 27 '23 09:01 SimenB

Hi @joshkel ✋ Following your recent fix (#13810), I pushed this PR that will use the getObjectKeys function in subsetEquality. I need to add a regression test as well. Can you give me an example where getObjectKeys produces a different output than Reflect.ownKeys?

lpizzinidev avatar Feb 11 '23 13:02 lpizzinidev

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

github-actions[bot] avatar Mar 18 '23 00:03 github-actions[bot]