seti-ui icon indicating copy to clipboard operation
seti-ui copied to clipboard

Enhance JS/JSX and TS/TSX

Open birkskyum opened this issue 1 year ago • 2 comments
trafficstars

While React did popularize the JSX/TSX syntax, there is an increasing number of libraries other than react that rely on JSX/TSX. Notable examples are SolidJS, Vue and Preact which can use the .tsx/.jsx extensions, or in the case of vue have a .vue allowing it to have a dedicated icon.

To account for this diverse ecosystem, this PR therefore remove an obsolete assumption that "jsx = react" and changes the jsx/tsx to a jsx/tsx icons accordingly. This also making jsx<->tsx migration a bit easier, while keeping the spec / test colors as they are, in accordance with https://github.com/jesseweed/seti-ui/pull/611.

Before Screenshot 2024-03-18 at 22 06 25

After Screenshot 2024-03-18 at 22 18 35

birkskyum avatar Mar 18 '24 21:03 birkskyum

@orta , what are your thoughts on this?

birkskyum avatar Nov 30 '24 16:11 birkskyum

I'm not wild on the change personally, unless the vscode team have opinions, it's probably not something I'd merge

I think your reasoning is pretty solid, but I don't think it's worth changing everyones defaults for

orta avatar Dec 04 '24 15:12 orta