Results 406 comments of roryqi

@advancedxy @LuciferYang Do you have any suggestion about this issue?

Maybe we could remove ``` if (readBuffer != null) { RssUtils.releaseByteBuffer(readBuffer); } ``` Because we have released the ByteBuf ``` if (sdr != null) { sdr.release(); // We set sdr...

> I also hit the same issue. In my case, readBuffer is an instance of DirectByteBuffer and readBuffer#cleaner is null and readBuffer#attachment is not null. Since readBuffer#cleaner is null, PlatformDependent.freeDirectBuffer...

Why do we put them in one package? Because we want to use default package method easily.

This is a breaking change, too. If you need to extend and use some default privilege methods, it will be inconvenient. Conflicts won't be a big issue. I prefer not...

Usually principal names are in the form 'user/instance@REALM' or 'user@REALM'.

> This modification applies to both 'user/instance@REALM' and 'user@REALM'. I can't get your point. Why do we need the modification? If you don't want the use the 'user/instance' as the...

> Why don't you change it to support both ‘user1@REALM’and ‘user1/group@REALM’ mapping to ‘user1’, instead of forcing to use 'user1@REALM' ? For Kerberos `user1/instance1` and `user1/instance2` is two principals. It...