sample-angular-oauth2-oidc-with-auth-guards

sample-angular-oauth2-oidc-with-auth-guards copied to clipboard

Storage events can cause race conditions

7

In the `auth-service` there is [a storage event listener](https://github.com/jeroenheijmans/sample-angular-oauth2-oidc-with-auth-guards/blob/0ab656ecface48fe0faf21e7ded0888ab747921e/src/app/auth.service.ts#L49) added. This might cause race conditions. For example: 1. Tab A and Tab B both have the app open, not logged...

jeroenheijmans

Add observable to indicate if User Profile was loaded

2

In the main service of this sample we load the User Profile like this: https://github.com/jeroenheijmans/sample-angular-oauth2-oidc-with-auth-guards/blob/4ee8e2862bb9b825015a9bd5213d07984c9cea13/src/app/core/auth.service.ts#L73-L75 I suspect some people will want to "wait" for the profile to be loaded before...

jeroenheijmans

A bunch of people have started using this repo as a starting point. They might even copy/paste pieces into production applications. Especially these seem important: - `auth.service.ts` and notably logic...

jeroenheijmans

The error field has moved to result.params.error on the latest keycloak version

2

https://github.com/jeroenheijmans/sample-angular-oauth2-oidc-with-auth-guards/blob/ac3eb39c4d368f711b814d3a4d02045666b276cc/src/app/core/auth.service.ts#L126

eciuca

Update or remove Implicit Flow branch

2

[Someone let us know that the `implicit-flow` branch is broken](https://github.com/manfredsteyer/angular-oauth2-oidc/issues/872#issuecomment-656361130) at the moment. The [`implicit-flow` branch](https://github.com/jeroenheijmans/sample-angular-oauth2-oidc-with-auth-guards/tree/implicit-flow) [relies on `demo.identityserver.io`](https://github.com/jeroenheijmans/sample-angular-oauth2-oidc-with-auth-guards/blob/9ad194afcecf1b8d903e863931ee6f366a638876/src/app/core/auth-config.ts#L3-L14) which [recently removed the `implicit` client](https://github.com/IdentityServer/IdentityServer4.Demo/commit/ab6c5b81810fe4f7d644f93fa81945b2e87a4c55#diff-f081df7a8d087fe79f951a1b2ea6dae3L301-L315) completely. Three options: - remove...

jeroenheijmans

Add extra e2e test that exercises some other features

1

The current basic e2e test just boots up the app. The happy-path-flow e2e test will log the user in and out via the login button. This leaves a few components...

jeroenheijmans

The attempt at silent refresh during the runInitialLoginSequence method can cause extremely long page loads if no token is present depending on the server used

2

There should be a check to see if the access token is null before attempting the silent refresh near the end of the initial login script. Without it, the silent...

NickSt

Consider dropping silent-refresh/iframe by using refresh endpoint

3

Hi, Would you consider a PR that would drop silent-refresh using iframe by replacing it by calling refresh endpoint ? This would add following benefits: - Better handling of historic...

beltschatsar

Application logs out too quickly in Firefox

1

I have cloned the repository, `npm install`ed the dependencies, and `npm start`ed the dev server. Works. I opened the app in Firefox v107.0 I then went to the Admin 2...

MatthiasvB