jeremyjpj0916

Results 114 comments of jeremyjpj0916
trafficstars

Hmm actually looks like if we took this specific snippit: https://github.com/SpiderLabs/ModSecurity-nginx/pull/165/files#diff-6fc03fd6024a7ec57f5c46d276d27548R44 Then even executing the log phase logic of modsec would get avoided and save the incorrect logging. Didn't realize...

^ So following up on that test, seems to add **that does indeed prevent the audit log from being written with the incorrect information**. But ngx error output still receives...

Well honestly less to change if we just do it here, I see no major drawbacks, ModSecurity should really not intervene on error_page directive paths for internal redirects at all...

Ugh, and then the above code stops the invalid ngx error logging BUT it also prevents me from getting valid audit logs too. The std out still has the valid...

Yeah trying to do hacky checks around short circuiting with the ```r->error_page``` check in various phases makes this difficult, I can't seem to satisfy all constraints(make ngx error logs and...

@martinhsv That may work, but lets say that mod security itself is going to block a tx upon request and sets a 400/403 response and error_page is set to handle...

@martinhsv Took a nap but got around to testing your idea there. Yep the behavior seen when attempting such a suggestion is the error log does still work on a...

@martinhsv Yeah had not given that too much thought but I could remove rule by id for example on the rule triggered by seeing GET with HTTP Body in the...

@hator So to talk to your specific idea could we use this one for example? https://github.com/Kong/kong/blob/master/kong/templates/nginx_kong.lua Where I just replace here: https://github.com/Kong/kong/blob/master/kong/templates/nginx_kong.lua#L82 and https://github.com/Kong/kong/blob/master/kong/templates/nginx_kong.lua#L83 with ``` error_page 400 404 408...