critic icon indicating copy to clipboard operation
critic copied to clipboard

Github integration makes links go to /home

Open zcorpan opened this issue 12 years ago • 5 comments

e.g. http://critic.hoppipolla.co.uk/r/8 when I click the link, I end up at http://critic.hoppipolla.co.uk/home . If I navigate to the first URL again then it works.

Maybe this has something to do with the github integration.

zcorpan avatar Mar 18 '13 13:03 zcorpan

Yes, this is a missing feature in my code (it always redirects to / after auth.). Not landed in critic mainline yet :)

jgraham avatar Mar 18 '13 14:03 jgraham

Any chance of a review showing up in critic.whyi.org any time soon? ;-)

jensl avatar Mar 18 '13 14:03 jensl

Yes, I just need to remove the bits that don't work at all; there seems little point in reviewing those :) Also I probably need a user account on that critic instance.

jgraham avatar Mar 18 '13 14:03 jgraham

A user account is easy to fix. To what email address should I send details? (And what username do you prefer?)

jensl avatar Mar 18 '13 14:03 jensl

Is there documentation for GitHub integration? I sometimes suggest small FOSS projects to use it when they say they need some code review system. But it's a bit hard saying what's needed to be done. It might even be possible to set up one instance that many unrelated projects could use as a service?

Also, to be slightly more relevant, this patch has still not surfaced into upstream? :P

odinho avatar Feb 28 '15 12:02 odinho