workflow-job-plugin icon indicating copy to clipboard operation
workflow-job-plugin copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

[JENKINS-56734] Fix prefix ending up outside of console

Open faircreek opened this issue 6 years ago • 3 comments
trafficstars

See JENKINS-56734.

Pipeline prefixes how it looked in 2.25 pipeline_prefix_how_it_looks_in_2 25

How it looks in 2.32 pipeline_prefix_bug_2

This might be somewhat ok with short prefixes but with long ones it becomes hard to read. pipeline_prefix_bug

It's a very small change to make it look like in 2.25.

faircreek avatar Mar 13 '19 08:03 faircreek

Thanks for the PR! See #111 for additional context around the change that added the current visualization after the log-handling rewrite removed the branches from the log itself. If we make this change I feel like it might make more sense to just move the branches back into the log itself so that they are also searchable via ctrl+f in most browsers. CC @jglick

dwnusbaum avatar Mar 13 '19 23:03 dwnusbaum

Yep that is probably the easiest. In re to #111 that I didn't read before, I did actually figuring out what you tried to achieve. Better is probably two "columns" one right adjusted for the prefixes and one left adjusted for the log. The whole thing does need to be in the console area though. This is doable by calculating string lengths and the adjust the padding dynamically. The question is how it will look with very long prefixes, line wrapping and such.

faircreek avatar Mar 14 '19 10:03 faircreek

Rather than shifting the placement it may make more sense to trim long branch names and make the full version available via tooltip or similar.

Searchability is an independent question.

jglick avatar Mar 18 '19 18:03 jglick