workflow-cps-plugin icon indicating copy to clipboard operation
workflow-cps-plugin copied to clipboard

JENKINS-73941 - Option to hide "Use Groovy Sandbox" for users without Administer permission globally in the system

Open jgarciacloudbees opened this issue 1 year ago • 3 comments

JENKINS-73941

This is partially implemented in JENKINS-73470, where we created the new option "Hide Sandbox checkbox in pipeline jobs", but it was created in the scope of this plugin.

The scope of this ticket is just to create the global option at the "script-security-plugin", to be used by all plugins depending on the sandbox.

Script Security Plugin PR including this change: https://github.com/jenkinsci/script-security-plugin/pull/584

Testing done

Created new test method covering the changes + CASC.

Submitter checklist

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [x] Link to relevant issues in GitHub or Jira
  • [x] Link to relevant pull requests, esp. upstream and downstream changes
  • [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

jgarciacloudbees avatar Oct 22 '24 14:10 jgarciacloudbees

Closing and reopening to run again the checks as there are some flaky failures

jgarciacloudbees avatar Oct 24 '24 08:10 jgarciacloudbees

Created new test method covering the changes + CASC.

https://github.com/jenkinsci/workflow-cps-plugin/pull/948#discussion_r1815518209 There is no JCasC test here that I can see.

jglick avatar Oct 24 '24 18:10 jglick

Hi @jglick, we have implemented the CASC compatibility, so the breaking change does not apply after the latest commit. Can you please remove the breaking label?

jgarciacloudbees avatar Oct 25 '24 15:10 jgarciacloudbees