workflow-api-plugin icon indicating copy to clipboard operation
workflow-api-plugin copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

Delete `GCFlushedOutputStream`

Open dwnusbaum opened this issue 7 months ago • 1 comments

See https://github.com/jenkinsci/workflow-api-plugin/pull/83#discussion_r2018964003. Alternative to https://github.com/jenkinsci/workflow-api-plugin/pull/388.

Testing done

Existing tests here pass for me locally, but if we want to go through with this we need to run it through the PCT.

Submitter checklist

  • [ ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [ ] Ensure that the pull request title represents the desired changelog entry
  • [ ] Please describe what you did
  • [ ] Link to relevant issues in GitHub or Jira
  • [ ] Link to relevant pull requests, esp. upstream and downstream changes
  • [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

dwnusbaum avatar Mar 28 '25 18:03 dwnusbaum

Prefer #388 but I only have a dim memory of what this was (supposed to be) solving. Perhaps remote TaskListeners which never get flushed before the callable exits?

jglick avatar Apr 08 '25 17:04 jglick

https://github.com/jenkinsci/workflow-api-plugin/pull/388 now has a test that requires GCFlushedOutputStream, so we can at least verify that it works as intended under specialized conditions. I'm closing this in favor of that PR for now. However, if that PR turns out to cause any problems, then we should just delete the whole class instead.

dwnusbaum avatar Jul 07 '25 22:07 dwnusbaum