support-core-plugin icon indicating copy to clipboard operation
support-core-plugin copied to clipboard

[chore] No point for CustomLogs to be enabled by default

Open Dohbedoh opened this issue 1 year ago • 2 comments
trafficstars

Testing done

Submitter checklist

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [ ] Please describe what you did
  • [ ] Link to relevant issues in GitHub or Jira
  • [ ] Link to relevant pull requests, esp. upstream and downstream changes
  • [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Dohbedoh avatar May 20 '24 08:05 Dohbedoh

OK I guess? Not sure why particular components are marked to be enabled by default and others are not; I would tend to think that if you went to the trouble of setting up a custom log recorder, it is probably because these messages were important to review, and they are possibly the most interesting things in a bundle.

BTW chore is the wrong label for a user-visible behavioral change. Use either enhancement or bug.

jglick avatar May 20 '24 11:05 jglick

It thought it could help to prevent scenario where someone generate bundle and share it somewhere without paying attention of currently enabled customer loggers. Though they should since it is enabled by default. And some logger may log sensitive info - typically http client internal packages that print headers. I know this is not solving the source of that problem but may as well alleviate it.

Dohbedoh avatar May 20 '24 23:05 Dohbedoh