durable-task-plugin icon indicating copy to clipboard operation
durable-task-plugin copied to clipboard

No need for an explicit dep on Hamcrest

Open jglick opened this issue 1 year ago • 1 comments
trafficstars

https://github.com/jenkinsci/durable-task-plugin/pull/222#pullrequestreview-2219707164 https://github.com/jenkinsci/durable-task-plugin/pull/223 Normally included in all plugins via jenkins-test-harness, and in this case also via awaitility.

jglick avatar Aug 06 '24 17:08 jglick

as it is used it directly it should have an explicit dep

Perhaps, but the same could be said of 90% of Jenkins plugins, and this is the only one I am familiar with which declares the dep explicitly. (As of your #152, apparently.) Unless you propose to activate the Enforcer rule which would mandate use of explicit dependencies, this seems like a gratuitous inconsistency.

jglick avatar Aug 06 '24 18:08 jglick