bitbucket-push-and-pull-request-plugin
bitbucket-push-and-pull-request-plugin copied to clipboard
Some log messages don't print their parameters anymore
Problem
Some log messages have most likely been accidentally changed to the wrong format and now their parameters are not logged. For example in io.jenkins.plugins.bitbucketpushandpullrequest.observer.BitBucketPPRObserverFactory#createObservable all log messages have {} instead of {0}. E.g:
if (PULL_REQUEST_SERVER_EVENT.equals(bitbucketEvent.getEvent())) {
logger.log(Level.FINE, "Add BitBucketPPRPullRequestServerObserver for {}", bitbucketEvent);
observable.addObserver(new BitBucketPPRPullRequestServerObserver());
}
This is what gets written to the logs: Add BitBucketPPRPullRequestServerObserver for {}
Impact
This makes throubleshooting difficult especially in case of exceptions as the real message is not visible in the log. For instance io.jenkins.plugins.bitbucketpushandpullrequest.client.BitBucketPPRClientCloudVisitor#send(com.cloudbees.plugins.credentials.common.StandardCredentials, com.github.scribejava.core.model.Verb, java.lang.String, java.lang.String).
Solution Need to change the log message pattern back.